-
Notifications
You must be signed in to change notification settings - Fork 183
[WIP] exchange cloud ID #4417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[WIP] exchange cloud ID #4417
Conversation
Current code is mostly POC and getting familiar with contacts code base. Questions:
|
ea81812
to
7c0eaa0
Compare
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4417 +/- ##
===========================================
- Coverage 11.03% 2.22% -8.82%
===========================================
Files 122 99 -23
Lines 5589 4989 -600
Branches 1209 1261 +52
===========================================
- Hits 617 111 -506
+ Misses 4850 4756 -94
Partials 122 122 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Thanks for the contribution, @redblom!
Is there any way this could work without introducing an app dependency? |
Short answer: No, that is to say, the actual cloud ID exchange is not a responsibility of the contacts app but the contacts app (the cloud ID field) is a logical place where to have this option (as per earlier discussion with the Design Team). |
71103c9
to
0112a78
Compare
- create dedicated cloud ID property component
0112a78
to
e7c2604
Compare
Thanks for the clarification |
This is a work in progress
This PR implements #4416