Skip to content

[WIP] exchange cloud ID #4417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

redblom
Copy link

@redblom redblom commented Apr 8, 2025

This is a work in progress
This PR implements #4416

@hamza221 hamza221 added enhancement New feature or request 2. developing Work in progress labels Apr 8, 2025
@hamza221 hamza221 marked this pull request as draft April 8, 2025 09:14
@redblom
Copy link
Author

redblom commented Apr 8, 2025

Current code is mostly POC and getting familiar with contacts code base.

Questions:

  • after pressing send button on the invitation form the ContactDetails.editMode property should be set to false to display the contact (same behavior as pressing the contact save button). How do we do that?
    Would a custom PropertyCloudId component to be used instead of ContactDetailsProperty for the cloud ID field make sense?
    Or should we simply forward/bind the editMode flag to the ContactDetailsProperty --> PropertyText --> CloudIdExchangeInvite component chain.

    Use a dedicated PropertyCloudId component (based on PropertyText with additional 'invite', 'accept', 'decline', 'revoke' buttons).
  • After closing the send invitation form (click 'Send') and setting the ContactDetails edit mode to false the email is not immediately show, how's that?

@hamza221 hamza221 added this to the v7.1.0 milestone Apr 10, 2025
@redblom redblom force-pushed the invite-for-cloudid-exchange branch from ea81812 to 7c0eaa0 Compare April 10, 2025 20:45
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Copy link

codecov bot commented Apr 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 139 lines in your changes missing coverage. Please review.

Project coverage is 2.22%. Comparing base (0714ac0) to head (e7c2604).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
src/components/Properties/PropertyCloudId.vue 0.00% 75 Missing ⚠️
src/components/CloudIdExchangeInvite.vue 0.00% 49 Missing ⚠️
...mponents/ContactDetails/ContactDetailsProperty.vue 0.00% 6 Missing ⚠️
src/components/CloudIdExchangeInviteDetails.vue 0.00% 5 Missing ⚠️
src/views/Contacts.vue 0.00% 4 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (0714ac0) and HEAD (e7c2604). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (0714ac0) HEAD (e7c2604)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##               main   #4417      +/-   ##
===========================================
- Coverage     11.03%   2.22%   -8.82%     
===========================================
  Files           122      99      -23     
  Lines          5589    4989     -600     
  Branches       1209    1261      +52     
===========================================
- Hits            617     111     -506     
+ Misses         4850    4756      -94     
  Partials        122     122              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ChristophWurst
Copy link
Member

Thanks for the contribution, @redblom!

The features relies on an implementation of the Invitation Workflow (see https://github.com/sara-nl/nc-collaboration).

Is there any way this could work without introducing an app dependency?

@hamza221 hamza221 modified the milestones: v7.1.0, v7.2.0 Apr 28, 2025
@redblom
Copy link
Author

redblom commented Apr 29, 2025

Thanks for the contribution, @redblom!

The features relies on an implementation of the Invitation Workflow (see https://github.com/sara-nl/nc-collaboration).

Is there any way this could work without introducing an app dependency?

Short answer: No, that is to say, the actual cloud ID exchange is not a responsibility of the contacts app but the contacts app (the cloud ID field) is a logical place where to have this option (as per earlier discussion with the Design Team).
The feature actually depends on the implementation of OCM /invite-accepted. This is currently in the process of being implemented for nextcloud server core (nextcloud/server#51113) so cloud ID exchange can become an integral part of nextcloud. Up until then there should be an app present implementing this.
The idea is to make the option not visible to the user when the platform can not do the actual cloud ID exchange (by configuration).
(so the best answer is: yes, when cloud ID exchange has become an integral part of nextcloud :)

@redblom redblom force-pushed the invite-for-cloudid-exchange branch from 71103c9 to 0112a78 Compare April 30, 2025 12:21
 - create dedicated cloud ID property component
@redblom redblom force-pushed the invite-for-cloudid-exchange branch from 0112a78 to e7c2604 Compare April 30, 2025 14:32
@ChristophWurst
Copy link
Member

Thanks for the clarification

@ChristophWurst ChristophWurst requested review from ArtificialOwl and removed request for hamza221, GVodyanov and SebastianKrupinski May 15, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress enhancement New feature or request feedback-requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants